pgsql: pgstat: stats collector references in comments.

From: Andres Freund <andres(at)anarazel(dot)de>
To: pgsql-committers(at)lists(dot)postgresql(dot)org
Subject: pgsql: pgstat: stats collector references in comments.
Date: 2022-04-06 20:57:57
Message-ID: E1ncCiz-000dFF-8O@gemulon.postgresql.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

pgstat: stats collector references in comments.

Soon the stats collector will be no more, with statistics instead getting
stored in shared memory. There are a lot of references to the stats collector
in comments. This commit replaces most of these references with "cumulative
statistics system", with the remaining ones getting replaced as part of
subsequent commits.

This is done separately from the - quite large - shared memory statistics
patch to make review easier.

Author: Andres Freund <andres(at)anarazel(dot)de>
Reviewed-By: Justin Pryzby <pryzby(at)telsasoft(dot)com>
Reviewed-By: Thomas Munro <thomas(dot)munro(at)gmail(dot)com>
Reviewed-By: Kyotaro Horiguchi <horikyota(dot)ntt(at)gmail(dot)com>
Discussion: https://postgr.es/m/20220303021600.hs34ghqcw6zcokdh@alap3.anarazel.de
Discussion: https://postgr.es/m/20220308205351.2xcn6k4x5yivcxyd@alap3.anarazel.de

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/bdbd3d9064f9dbd064253e05f156ec77d4a90d05

Modified Files
--------------
contrib/test_decoding/t/001_repl_stats.pl | 3 +--
src/backend/access/heap/heapam_handler.c | 4 ++--
src/backend/access/heap/vacuumlazy.c | 8 +++----
src/backend/commands/analyze.c | 2 +-
src/backend/commands/dbcommands.c | 2 +-
src/backend/commands/matview.c | 8 +++----
src/backend/commands/subscriptioncmds.c | 4 ++--
src/backend/commands/vacuum.c | 4 ++--
src/backend/postmaster/autovacuum.c | 14 ++++++------
src/backend/postmaster/bgwriter.c | 4 +---
src/backend/postmaster/checkpointer.c | 14 ++++--------
src/backend/postmaster/pgarch.c | 8 +++----
src/backend/postmaster/pgstat.c | 28 ++++++++++++------------
src/backend/postmaster/walwriter.c | 9 ++++----
src/backend/replication/basebackup.c | 4 ++--
src/backend/tcop/postgres.c | 8 +++----
src/backend/utils/activity/pgstat_archiver.c | 3 +--
src/backend/utils/activity/pgstat_bgwriter.c | 2 +-
src/backend/utils/activity/pgstat_checkpointer.c | 2 +-
src/backend/utils/activity/pgstat_database.c | 14 ++++++------
src/backend/utils/activity/pgstat_relation.c | 16 +++++++-------
src/backend/utils/activity/pgstat_replslot.c | 10 ++++-----
src/backend/utils/activity/pgstat_slru.c | 3 +--
src/backend/utils/activity/pgstat_subscription.c | 8 +++----
src/backend/utils/adt/pgstatfuncs.c | 4 ++--
src/backend/utils/error/elog.c | 2 +-
src/include/pgstat.h | 4 ++--
src/include/utils/backend_status.h | 4 ++--
src/include/utils/pgstat_internal.h | 2 +-
src/test/regress/expected/stats.out | 2 +-
src/test/regress/sql/stats.sql | 2 +-
31 files changed, 95 insertions(+), 107 deletions(-)

Browse pgsql-committers by date

  From Date Subject
Next Message Tom Lane 2022-04-06 21:04:04 pgsql: Suppress "variable 'pagesaving' set but not used" warning.
Previous Message Andres Freund 2022-04-06 20:25:30 pgsql: pgstat: move transactional code into pgstat_xact.c.