pgsql: Modify query on pg_hba_file_rules to check for errors in regress

From: Michael Paquier <michael(at)paquier(dot)xyz>
To: pgsql-committers(at)lists(dot)postgresql(dot)org
Subject: pgsql: Modify query on pg_hba_file_rules to check for errors in regress
Date: 2022-03-29 00:09:22
Message-ID: E1nYzQH-001pFQ-ST@gemulon.postgresql.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

Modify query on pg_hba_file_rules to check for errors in regression tests

The regression tests include a query to check the execution path of
pg_hba_file_rules, but it has never checked that a given cluster has
correct contents in pg_hba.conf. This commit extends the query of
pg_hba_file_rules to report any errors if anything bad is found. For
EXEC_BACKEND builds, any connection attempt would fail when loading
pg_hba.conf if any incorrect content is found when parsed, so a failure
would be detected before even running this query. However, this can
become handy for clusters where pg_hba.conf can be reloaded, where new
connection attempts are not subject to a fresh loading of pg_hba.conf.

Author: Julien Rouhaud, based on an idea from me
Discussion: https://postgr.es/m/YkFhpydhyeNNo3Xl@paquier.xyz

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/091a971bb59ca9751f32a4aa5aee969c5a915754

Modified Files
--------------
src/test/regress/expected/sysviews.out | 11 ++++++-----
src/test/regress/sql/sysviews.sql | 5 +++--
2 files changed, 9 insertions(+), 7 deletions(-)

Browse pgsql-committers by date

  From Date Subject
Next Message Michael Paquier 2022-03-29 01:16:36 pgsql: Add system view pg_ident_file_mappings
Previous Message Andrew Dunstan 2022-03-28 19:37:30 pgsql: IS JSON predicate