pgsql: Wait for subscription to sync in t/031_column_list.sql

From: Tomas Vondra <tomas(dot)vondra(at)postgresql(dot)org>
To: pgsql-committers(at)lists(dot)postgresql(dot)org
Subject: pgsql: Wait for subscription to sync in t/031_column_list.sql
Date: 2022-03-26 23:36:02
Message-ID: E1nYFwv-001Wul-Kv@gemulon.postgresql.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

Wait for subscription to sync in t/031_column_list.sql

One of the TAP tests added in 923def9a53 did not wait after creating a
subscription, and wait_for_catchup is not sufficient for this. So if the
tablesync workers happen do not complete quickly enough, the test won't
see the expected results.

This probably explains intermittent failures on a couple buildfarm
animals (komodoensis, petalura and snapper).

Reported-by: Tom Lane
Discussion: https://postgr.es/m/170549.1648330634@sss.pgh.pa.us

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/404f49338fef32150f930ddfa8ae0411b5e35121

Modified Files
--------------
src/test/subscription/t/031_column_list.pl | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

Browse pgsql-committers by date

  From Date Subject
Next Message Michael Paquier 2022-03-27 08:55:36 pgsql: pageinspect: Add more sanity checks to prevent out-of-bound read
Previous Message Tom Lane 2022-03-26 23:28:07 Re: pgsql: Add 'basebackup_to_shell' contrib module.