pgsql: pg_upgrade: Upgrade an Assert to a real 'if' test

From: Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org>
To: pgsql-committers(at)lists(dot)postgresql(dot)org
Subject: pgsql: pg_upgrade: Upgrade an Assert to a real 'if' test
Date: 2022-03-23 18:26:15
Message-ID: E1nX5gU-0013cw-Vw@gemulon.postgresql.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

pg_upgrade: Upgrade an Assert to a real 'if' test

It seems possible for the condition being tested to be true in
production, and nobody would never know (except when some data
eventually becomes corrupt?).

Author: Álvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org>
Discussion: https://postgr.es/m//202109040001(dot)zky3wgv2qeqg(at)alvherre(dot)pgsql

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/3e1c942a4e2f06e9b0196180eb8fd1383e6d788e

Modified Files
--------------
src/bin/pg_rewind/parsexlog.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)

Responses

Browse pgsql-committers by date

  From Date Subject
Next Message Alvaro Herrera 2022-03-23 18:28:47 Re: pgsql: pg_upgrade: Upgrade an Assert to a real 'if' test
Previous Message Robert Haas 2022-03-23 17:27:04 pgsql: pg_basebackup: Try to fix some failures on Windows.