From: | Andres Freund <andres(at)anarazel(dot)de> |
---|---|
To: | pgsql-committers(at)lists(dot)postgresql(dot)org |
Subject: | pgsql: Add missing dependency of pg_dumpall to WIN32RES. |
Date: | 2022-03-22 15:29:31 |
Message-ID: | E1nWgRu-000srN-Ip@gemulon.postgresql.org |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-committers |
Add missing dependency of pg_dumpall to WIN32RES.
When cross-building to windows, or building with mingw on windows, the build
could fail with
x86_64-w64-mingw32-gcc: error: win32ver.o: No such file or director
because pg_dumpall didn't depend on WIN32RES, but it's recipe references
it. The build nevertheless succeeded most of the time, due to
pg_dump/pg_restore having the required dependency, causing win32ver.o to be
built.
Reported-By: Thomas Munro <thomas(dot)munro(at)gmail(dot)com>
Discussion: https://postgr.es/m/CA+hUKGJeekpUPWW6yCVdf9=oBAcCp86RrBivo4Y4cwazAzGPng@mail.gmail.com
Backpatch: 10-, omission present on all live branches
Branch
------
master
Details
-------
https://git.postgresql.org/pg/commitdiff/097786fbbb58897fec12ed9bfff3940c77b5867b
Modified Files
--------------
src/bin/pg_dump/Makefile | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
From | Date | Subject | |
---|---|---|---|
Next Message | Andrew Dunstan | 2022-03-22 17:35:40 | pgsql: Fix new Object Access hooks test |
Previous Message | Andres Freund | 2022-03-22 15:16:07 | pgsql: pgstat: fix function name in comment. |