From: | Thomas Munro <tmunro(at)postgresql(dot)org> |
---|---|
To: | pgsql-committers(at)lists(dot)postgresql(dot)org |
Subject: | pgsql: Fix waiting in RegisterSyncRequest(). |
Date: | 2022-03-16 02:49:14 |
Message-ID: | E1nUJis-000GEQ-Lm@gemulon.postgresql.org |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-committers |
Fix waiting in RegisterSyncRequest().
If we run out of space in the checkpointer sync request queue (which is
hopefully rare on real systems, but common with very small buffer pool),
we wait for it to drain. While waiting, we should report that as a wait
event so that users know what is going on, and also handle postmaster
death, since otherwise the loop might never terminate if the
checkpointer has exited.
Back-patch to 12. Although the problem exists in earlier releases too,
the code is structured differently before 12 so I haven't gone any
further for now, in the absence of field complaints.
Reported-by: Andres Freund <andres(at)anarazel(dot)de>
Reviewed-by: Andres Freund <andres(at)anarazel(dot)de>
Discussion: https://postgr.es/m/20220226213942.nb7uvb2pamyu26dj%40alap3.anarazel.de
Branch
------
master
Details
-------
https://git.postgresql.org/pg/commitdiff/3390ef1b7be28eac24dd95af23a4a287e6e7b1a4
Modified Files
--------------
doc/src/sgml/monitoring.sgml | 5 +++++
src/backend/storage/sync/sync.c | 4 +++-
src/backend/utils/activity/wait_event.c | 3 +++
src/include/utils/wait_event.h | 1 +
4 files changed, 12 insertions(+), 1 deletion(-)
From | Date | Subject | |
---|---|---|---|
Next Message | Thomas Munro | 2022-03-16 02:49:26 | pgsql: Fix waiting in RegisterSyncRequest(). |
Previous Message | Michael Paquier | 2022-03-16 02:45:14 | Re: pgsql: pageinspect: Fix handling of page sizes and AM types |