pgsql: Add further debug info to help debug 019_replslot_limit.pl failu

From: Andres Freund <andres(at)anarazel(dot)de>
To: pgsql-committers(at)lists(dot)postgresql(dot)org
Subject: pgsql: Add further debug info to help debug 019_replslot_limit.pl failu
Date: 2022-02-26 01:05:25
Message-ID: E1nNlWW-000Nyd-8s@gemulon.postgresql.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

Add further debug info to help debug 019_replslot_limit.pl failures.

See also afdeff10526. Failures after that commit provided a few more hints,
but not yet enough to understand what's going on.

In 019_replslot_limit.pl shut down nodes with fast instead of immediate mode
if we observe the failure mode. That should tell us whether the failures we're
observing are just a timing issue under high load. PGCTLTIMEOUT should prevent
buildfarm animals from hanging endlessly.

Also adds a bit more logging to replication slot drop and ShutdownPostgres().

Discussion: https://postgr.es/m/20220225192941.hqnvefgdzaro6gzg@alap3.anarazel.de

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/fe0972ee5e6f8a663c5cf3f24ef98987c503da95

Modified Files
--------------
src/backend/replication/slot.c | 13 +++++++++++++
src/backend/storage/lmgr/lwlock.c | 7 +++++++
src/backend/utils/init/postinit.c | 17 +++++++++++++++++
src/include/storage/lwlock.h | 1 +
src/test/recovery/t/019_replslot_limit.pl | 18 +++++++++++++++++-
5 files changed, 55 insertions(+), 1 deletion(-)

Browse pgsql-committers by date

  From Date Subject
Next Message Amit Kapila 2022-02-26 05:16:36 pgsql: Fix typo in logicalfuncs.c.
Previous Message Tom Lane 2022-02-25 22:41:04 pgsql: Disallow execution of SPI functions during plperl function compi