pgsql: pg_waldump: Fix error message for WAL files smaller than XLOG_BL

From: Andres Freund <andres(at)anarazel(dot)de>
To: pgsql-committers(at)lists(dot)postgresql(dot)org
Subject: pgsql: pg_waldump: Fix error message for WAL files smaller than XLOG_BL
Date: 2022-02-25 18:48:41
Message-ID: E1nNfdw-000LaX-PV@gemulon.postgresql.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

pg_waldump: Fix error message for WAL files smaller than XLOG_BLCKSZ.

When opening a WAL file smaller than XLOG_BLCKSZ (e.g. 0 bytes long) while
determining the wal_segment_size, pg_waldump checked errno, despite errno not
being set by the short read. Resulting in a bogus error message.

Author: Kyotaro Horiguchi <horikyota(dot)ntt(at)gmail(dot)com>
Discussion: https://postgr.es/m/20220214.181847.775024684568733277.horikyota.ntt@gmail.com
Backpatch: 11-, the bug was introducedin fc49e24fa

Branch
------
REL_11_STABLE

Details
-------
https://git.postgresql.org/pg/commitdiff/51c34165614bde5d44a356ba5f1f4f79d8893103

Modified Files
--------------
src/bin/pg_waldump/pg_waldump.c | 16 ++++++++--------
1 file changed, 8 insertions(+), 8 deletions(-)

Browse pgsql-committers by date

  From Date Subject
Next Message Tom Lane 2022-02-25 22:41:04 pgsql: Disallow execution of SPI functions during plperl function compi
Previous Message Peter Geoghegan 2022-02-25 03:02:35 pgsql: vacuumlazy.c: Remove obsolete num_tuples field.