pgsql: Quick exit on log stream child exit in pg_basebackup

From: Daniel Gustafsson <dgustafsson(at)postgresql(dot)org>
To: pgsql-committers(at)lists(dot)postgresql(dot)org
Subject: pgsql: Quick exit on log stream child exit in pg_basebackup
Date: 2022-02-23 13:32:03
Message-ID: E1nMrkR-000Hod-W0@gemulon.postgresql.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

Quick exit on log stream child exit in pg_basebackup

If the log streaming child process (thread on Windows) dies during
backup then the whole backup will be aborted at the end of the
backup. Instead, trap ungraceful termination of the log streaming
child and exit early. This also adds a TAP test for simulating this
by terminating the responsible backend.

Reviewed-by: Michael Paquier <michael(at)paquier(dot)xyz>
Reviewed-by: Bharath Rupireddy <bharath(dot)rupireddyforpostgres(at)gmail(dot)com>
Reviewed-by: Magnus Hagander <magnus(at)hagander(dot)net>
Discussion: https://postgr.es/m/0F69E282-97F9-4DB7-8D6D-F927AA6340C8@yesql.se
Discussion: https://postgr.es/m/VI1PR83MB0189818B82C19059CB62E26199A89@VI1PR83MB0189.EURPRD83.prod.outlook.com

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/0475a97f744d2fea3676b2e69405d20358eac07a

Modified Files
--------------
src/bin/pg_basebackup/pg_basebackup.c | 47 ++++++++++++++++++++++++++--
src/bin/pg_basebackup/t/010_pg_basebackup.pl | 34 ++++++++++++++++++++
2 files changed, 79 insertions(+), 2 deletions(-)

Browse pgsql-committers by date

  From Date Subject
Next Message Tom Lane 2022-02-23 16:10:53 pgsql: Re-allow underscore as first character of custom GUC names.
Previous Message Daniel Gustafsson 2022-02-23 10:30:32 pgsql: Use test functions in pg_rewind test module