pgsql: Reset conn->errorReported when PQrequestCancel sets errorMessage

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: pgsql-committers(at)lists(dot)postgresql(dot)org
Subject: pgsql: Reset conn->errorReported when PQrequestCancel sets errorMessage
Date: 2022-02-20 20:02:47
Message-ID: E1nLsPv-0007vD-2A@gemulon.postgresql.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

Reset conn->errorReported when PQrequestCancel sets errorMessage.

Oversight in commit 618c16707. This is mainly neatnik-ism, since
if PQrequestCancel is used per its API contract, we should perform
pqClearConnErrorState before reaching any place that would consult
errorReported. But still, it seems like a bad idea to potentially
leave errorReported pointing past errorMessage.len.

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/83a7637e2c5be27a0788b920501dde284b3fca33

Modified Files
--------------
src/interfaces/libpq/fe-connect.c | 4 ++++
1 file changed, 4 insertions(+)

Browse pgsql-committers by date

  From Date Subject
Next Message Andres Freund 2022-02-20 22:16:36 pgsql: Fix meaning-changing typo introduced in fa0e03c15a9f.
Previous Message Andrew Dunstan 2022-02-20 16:53:00 pgsql: Remove most msys special processing in TAP tests