From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
---|---|
To: | pgsql-committers(at)lists(dot)postgresql(dot)org |
Subject: | pgsql: Suppress warning about stack_base_ptr with late-model GCC. |
Date: | 2022-02-18 03:46:24 |
Message-ID: | E1nKuDw-0002F9-9H@gemulon.postgresql.org |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-committers |
Suppress warning about stack_base_ptr with late-model GCC.
GCC 12 complains that set_stack_base is storing the address of
a local variable in a long-lived pointer. This is an entirely
reasonable warning (indeed, it just helped us find a bug);
but that behavior is intentional here. We can work around it
by using __builtin_frame_address(0) instead of a specific local
variable; that produces an address a dozen or so bytes different,
in my testing, but we don't care about such a small difference.
Maybe someday a compiler lacking that function will start to issue
a similar warning, but we'll worry about that when it happens.
Patch by me, per a suggestion from Andres Freund. Back-patch to
v12, which is as far back as the patch will go without some pain.
(Recently-established project policy would permit a back-patch as
far as 9.2, but I'm disinclined to expend the work until GCC 12
is much more widespread.)
Discussion: https://postgr.es/m/3773792.1645141467@sss.pgh.pa.us
Branch
------
REL_13_STABLE
Details
-------
https://git.postgresql.org/pg/commitdiff/46b738ffc2bf27c1c0bf0492f8c646c4496819dc
Modified Files
--------------
config/c-compiler.m4 | 22 ++++++++++++++++++++
configure | 40 +++++++++++++++++++++++++++++++++++++
configure.in | 3 +++
src/backend/postmaster/postmaster.c | 2 +-
src/backend/tcop/postgres.c | 12 ++++++++++-
src/backend/utils/init/miscinit.c | 11 +++++-----
src/include/pg_config.h.in | 3 +++
src/tools/msvc/Solution.pm | 1 +
8 files changed, 86 insertions(+), 8 deletions(-)
From | Date | Subject | |
---|---|---|---|
Next Message | Christoph Berg | 2022-02-18 09:39:09 | Re: pgsql: pg_upgrade: Preserve relfilenodes and tablespace OIDs. |
Previous Message | Fujii Masao | 2022-02-18 03:19:58 | pgsql: Fix comment in CheckIndexCompatible(). |