pgsql: Make origin data initialization consistent other fields in 2PC h

From: Michael Paquier <michael(at)paquier(dot)xyz>
To: pgsql-committers(at)lists(dot)postgresql(dot)org
Subject: pgsql: Make origin data initialization consistent other fields in 2PC h
Date: 2022-02-14 00:31:35
Message-ID: E1nJPHD-00013n-U3@gemulon.postgresql.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

Make origin data initialization consistent other fields in 2PC header

As of 1eb6d65, the origin data is optionally stored in a 2PC file
header, with the data filled in EndPrepare() even in the default case
where there is no origin data to add. This was inconsistent with all
the other fields of TwoPhaseFileHeader which are initialized in
StartPrepare(), so move the initialization of origin_lsn and
origin_timestamp there instead. The effect of missing the
initialization at this early stage is only cosmetic based on the current
logic of the code, but could have led to issues in the long-term, and it
is more consistent done this way.

Reported-by: Ranier Vilela
Discussion: https://postgr.es/m/CAEudQAooECJ+gU_RZB-yhioPOV94R4ucoHAf68PiJhLpgpVpBw@mail.gmail.com

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/c963e84fb8c8ec75bfdbe6a7a0857ccd1378baa0

Modified Files
--------------
src/backend/access/transam/twophase.c | 8 +++-----
1 file changed, 3 insertions(+), 5 deletions(-)

Browse pgsql-committers by date

  From Date Subject
Next Message Alexander Korotkov 2022-02-14 01:16:46 pgsql: Fix memory leak in IndexScan node with reordering
Previous Message Tom Lane 2022-02-14 00:21:05 pgsql: Fix misuse of "const" qualifier.