pgsql: Remove server support for old BASE_BACKUP command syntax.

From: Robert Haas <rhaas(at)postgresql(dot)org>
To: pgsql-committers(at)lists(dot)postgresql(dot)org
Subject: pgsql: Remove server support for old BASE_BACKUP command syntax.
Date: 2022-02-10 16:28:44
Message-ID: E1nICJI-00061F-Vz@gemulon.postgresql.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

Remove server support for old BASE_BACKUP command syntax.

Commit 0ba281cb4bf9f5f65529dfa4c8282abb734dd454 added a new syntax
for the BASE_BACKUP command, with extensible options, but maintained
support for the legacy syntax. This isn't important for PostgreSQL,
where pg_basebackup works with older server versions but not newer
ones, but it could in theory matter for out-of-core users of the
replication protocol.

Discussion on pgsql-hackers, however, suggests that no one is aware
of any out-of-core use of the BASE_BACKUP command, and the consensus
is in favor of removing support for the old syntax to simplify the
code, so do that.

Discussion: http://postgr.es/m/CA+TgmoazKcKUWtqVa0xZqSzbKgTH+X-aw4V7GyLD68EpDLMh8A@mail.gmail.com

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/9cd28c2e5f11dfeef64a14035b82e70acead65fd

Modified Files
--------------
doc/src/sgml/protocol.sgml | 11 ----
src/backend/replication/repl_gram.y | 97 ++--------------------------------
src/backend/replication/repl_scanner.l | 10 ----
3 files changed, 4 insertions(+), 114 deletions(-)

Browse pgsql-committers by date

  From Date Subject
Next Message Tom Lane 2022-02-10 16:52:43 pgsql: Make timeout.c more robust against missed timer interrupts.
Previous Message Daniel Gustafsson 2022-02-10 13:29:49 pgsql: Set SNI ClientHello extension to localhost in tests