pgsql: Add (void) cast in front of rmtree() call at the end of pg_upgra

From: Michael Paquier <michael(at)paquier(dot)xyz>
To: pgsql-committers(at)lists(dot)postgresql(dot)org
Subject: pgsql: Add (void) cast in front of rmtree() call at the end of pg_upgra
Date: 2022-02-07 05:27:36
Message-ID: E1nGwYq-0001Vd-D3@gemulon.postgresql.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

Add (void) cast in front of rmtree() call at the end of pg_upgrade

Most calls of rmtree() report an error, and the code coming from 38bfae3
has introduced one caller where this is not done. The previous behavior
was to not fail hard if any log file generated is not properly unlinked
when cleaning up the contents generated once the upgrade has completed,
so add a cast to (void) to indicate the intention behind this new code.

Per gripe from Coverity.

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/42a9e88bf6a809e6023c9d50f58cc6b9446f229d

Modified Files
--------------
src/bin/pg_upgrade/pg_upgrade.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

Browse pgsql-committers by date

  From Date Subject
Next Message Peter Eisentraut 2022-02-07 12:57:05 pgsql: Translation updates
Previous Message Tom Lane 2022-02-06 19:25:22 pgsql: Release notes for 14.2, 13.6, 12.10, 11.15, 10.20.