| From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
|---|---|
| To: | pgsql-committers(at)lists(dot)postgresql(dot)org |
| Subject: | pgsql: Remove configure's check for rl_completion_append_character. |
| Date: | 2022-02-03 04:02:05 |
| Message-ID: | E1nFTJt-0000sr-It@gemulon.postgresql.org |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-committers |
Remove configure's check for rl_completion_append_character.
The comment for PGAC_READLINE_VARIABLES says "Readline versions < 2.1
don't have rl_completion_append_character". It seems certain that such
versions are extinct in the wild, though; for sure there are none in the
buildfarm. Libedit has had this variable for at least twenty years too.
Also, tab-complete.c's behavior without it is quite unfriendly, since
we'll emit a space even when completion fails; but we've had no
complaints about that.
Therefore, let's assume this variable is always there, and drop the
configure check to save a few build cycles.
Discussion: https://postgr.es/m/147685.1643858911@sss.pgh.pa.us
Branch
------
master
Details
-------
https://git.postgresql.org/pg/commitdiff/4b0e37faaf5ffe1552a07438323341c6394890da
Modified Files
--------------
config/programs.m4 | 22 ++--------------------
configure | 41 +----------------------------------------
src/bin/psql/tab-complete.c | 10 +---------
src/include/pg_config.h.in | 4 ----
src/tools/msvc/Solution.pm | 1 -
5 files changed, 4 insertions(+), 74 deletions(-)
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Etsuro Fujita | 2022-02-03 06:22:58 | pgsql: Further fix for EvalPlanQual with mix of local and foreign parti |
| Previous Message | Bruce Momjian | 2022-02-03 02:54:17 | pgsql: doc: clarify syntax notation, particularly parentheses |