pgsql: Improve psql tab-completion tests.

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: pgsql-committers(at)lists(dot)postgresql(dot)org
Subject: pgsql: Improve psql tab-completion tests.
Date: 2022-02-02 21:09:14
Message-ID: E1nFMsM-0006ee-74@gemulon.postgresql.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

Improve psql tab-completion tests.

Fix up recently-added test cases in 010_tab_completion.pl
so that they pass with the rather seriously broken libedit
found in Debian 10 (Buster).

Also, add a few more test cases to improve code coverage.
The total line coverage still looks pretty awful, because
we exercise only a few paths of the giant if-else chain in
psql_completion(). However, this now covers almost all of
the code that isn't in one of those if-blocks.

Discussion: https://postgr.es/m/960764.1643751011@sss.pgh.pa.us

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/d33a81203e95d31e62157c4ae0e00e2198841208

Modified Files
--------------
src/bin/psql/t/010_tab_completion.pl | 103 ++++++++++++++++++++++++++++++++---
1 file changed, 95 insertions(+), 8 deletions(-)

Browse pgsql-committers by date

  From Date Subject
Next Message Andres Freund 2022-02-03 01:32:16 pgsql: ci: windows: run tests under timeout.
Previous Message Robert Haas 2022-02-02 18:59:20 pgsql: Fix server crash bug in 'server' backup target.