pgsql: pg_basebackup: Fix a couple of recently-introduced bugs.

From: Robert Haas <rhaas(at)postgresql(dot)org>
To: pgsql-committers(at)lists(dot)postgresql(dot)org
Subject: pgsql: pg_basebackup: Fix a couple of recently-introduced bugs.
Date: 2022-01-27 16:15:45
Message-ID: E1nD7R3-0002XT-SL@gemulon.postgresql.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

pg_basebackup: Fix a couple of recently-introduced bugs.

The server expects the compression level to be between 1 and 9, but
Z_DEFAULT_COMPRESSION is -1, so we must not try to send that value
to the server.

Because pg_basebackup's -R option is implemented on the client side,
it can't be used in combination with a backup target. Error out if
someone tries that, instead of silently ignoring the option.

Both issues were reported by Tushar Ahuja; patch by me.

Discussion: http://postgr.es/m/CA+TgmoaMwgdx8HxBjF8hmbohVvPL_0H5LqNrSq0uU+7BKp_Q2A@mail.gmail.com

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/dabf63bc9a5b71f61c2c8712c85d33fdc06efa8c

Modified Files
--------------
src/bin/pg_basebackup/pg_basebackup.c | 8 +++++++-
1 file changed, 7 insertions(+), 1 deletion(-)

Responses

Browse pgsql-committers by date

  From Date Subject
Next Message Peter Eisentraut 2022-01-27 17:31:20 pgsql: Remove some trailing whitespace in documentation files
Previous Message Andrew Dunstan 2022-01-27 13:28:20 pgsql: Improve msys2 detection for TAP tests