pgsql: Remember to reset yy_start state when firing up repl_scanner.l.

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: pgsql-committers(at)lists(dot)postgresql(dot)org
Subject: pgsql: Remember to reset yy_start state when firing up repl_scanner.l.
Date: 2022-01-24 17:10:08
Message-ID: E1nC2r2-0006uP-AQ@gemulon.postgresql.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

Remember to reset yy_start state when firing up repl_scanner.l.

Without this, we get odd behavior when the previous cycle of
lexing exited in a non-default exclusive state. Every other
copy of this code is aware that it has to do BEGIN(INITIAL),
but repl_scanner.l did not get that memo.

The real-world impact of this is probably limited, since most
replication clients would abandon their connection after getting
a syntax error. Still, it's a bug.

This mistake is old, so back-patch to all supported branches.

Discussion: https://postgr.es/m/1874781.1643035952@sss.pgh.pa.us

Branch
------
REL_10_STABLE

Details
-------
https://git.postgresql.org/pg/commitdiff/daf658982889451e6cdb9763482a03656407ae3e

Modified Files
--------------
src/backend/replication/repl_scanner.l | 3 +++
1 file changed, 3 insertions(+)

Browse pgsql-committers by date

  From Date Subject
Next Message Andrew Dunstan 2022-01-24 19:12:19 pgsql: Unbreak pg_basebackup/t/010_pg_basebackup.pl on msys
Previous Message Andres Freund 2022-01-24 07:34:38 pgsql: Temporarily add some information about python include paths to c