| From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
|---|---|
| To: | pgsql-committers(at)lists(dot)postgresql(dot)org |
| Subject: | pgsql: Clean up recent Coverity complaints. |
| Date: | 2022-01-23 17:51:44 |
| Message-ID: | E1nBh1k-0005me-9c@gemulon.postgresql.org |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-committers |
Clean up recent Coverity complaints.
Commit 5c649fe15 introduced a memory leak into pg_basebackup's
parse_compress_options. (I simplified nearby code while at it.)
Commit 9a974cbcb introduced a memory leak into pg_dump's
binary_upgrade_set_pg_class_oids.
Coverity also complained about a call of SnapBuildProcessChange that
ignored the result, unlike every other call of that function. This
is evidently intentional, so add a (void) cast to indicate that.
(It's also old, dating to b89e15105; I suppose the reason it showed
up now is 7a5f6b474's recent rearrangement of nearby code.)
Branch
------
master
Details
-------
https://git.postgresql.org/pg/commitdiff/353708e1fb2d8b1a34f6da2c25d4bb6633cf4493
Modified Files
--------------
src/backend/replication/logical/decode.c | 2 +-
src/bin/pg_basebackup/pg_basebackup.c | 9 +++++++--
src/bin/pg_dump/pg_dump.c | 3 ++-
3 files changed, 10 insertions(+), 4 deletions(-)
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tom Lane | 2022-01-23 18:54:35 | pgsql: pg_dump: avoid useless query in binary_upgrade_set_type_oids_by_ |
| Previous Message | Tom Lane | 2022-01-23 16:10:54 | pgsql: Suppress variable-set-but-not-used warning from clang 13. |