pgsql: Check syscache result in AlterStatistics

From: Tomas Vondra <tomas(dot)vondra(at)postgresql(dot)org>
To: pgsql-committers(at)lists(dot)postgresql(dot)org
Subject: pgsql: Check syscache result in AlterStatistics
Date: 2022-01-23 02:17:36
Message-ID: E1nBSRk-0007yL-RF@gemulon.postgresql.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

Check syscache result in AlterStatistics

The syscache lookup may return NULL even for valid OID, for example due
to a concurrent DROP STATISTICS, so a HeapTupleIsValid is necessary.
Without it, it may fail with a segfault.

Reported by Alexander Lakhin, patch by me. Backpatch to 13, where ALTER
STATISTICS ... SET STATISTICS was introduced.

Backpatch-through: 13
Discussion: https://postgr.es/m/17372-bf3b6e947e35ae77%40postgresql.org

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/6d554e3fcd6fb8be2dbcbd3521e2947ed7a552cb

Modified Files
--------------
src/backend/commands/statscmds.c | 2 ++
1 file changed, 2 insertions(+)

Browse pgsql-committers by date

  From Date Subject
Next Message Tomas Vondra 2022-01-23 02:22:39 pgsql: Check syscache result in AlterStatistics
Previous Message Tom Lane 2022-01-22 22:11:40 pgsql: Remove useless inline marker.