pgsql: TAP tests: check for postmaster.pid anyway when "pg_ctl start" f

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: pgsql-committers(at)lists(dot)postgresql(dot)org
Subject: pgsql: TAP tests: check for postmaster.pid anyway when "pg_ctl start" f
Date: 2022-01-19 21:29:30
Message-ID: E1nAIWI-0006ex-IN@gemulon.postgresql.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

TAP tests: check for postmaster.pid anyway when "pg_ctl start" fails.

"pg_ctl start" might start a new postmaster and then return failure
anyway, for example if PGCTLTIMEOUT is exceeded. If there is a
postmaster there, it's still incumbent on us to shut it down at
script end, so check for the PID file even though we are about
to fail.

This has been broken all along, so back-patch to all supported branches.

Discussion: https://postgr.es/m/647439.1642622744@sss.pgh.pa.us

Branch
------
REL_13_STABLE

Details
-------
https://git.postgresql.org/pg/commitdiff/6eec809fbcfbd8e0ab5e1c6485c7f53020f0d0b0

Modified Files
--------------
src/test/perl/PostgresNode.pm | 14 +++++++++++---
1 file changed, 11 insertions(+), 3 deletions(-)

Browse pgsql-committers by date

  From Date Subject
Next Message Tom Lane 2022-01-19 22:18:05 pgsql: interval_out() must be marked STABLE, not IMMUTABLE.
Previous Message Tom Lane 2022-01-19 20:39:08 pgsql: Make configure prefer python3 to plain python.