pgsql: Refactor set of routines specific to elog.c

From: Michael Paquier <michael(at)paquier(dot)xyz>
To: pgsql-committers(at)lists(dot)postgresql(dot)org
Subject: pgsql: Refactor set of routines specific to elog.c
Date: 2022-01-12 05:18:05
Message-ID: E1n7W1N-00079A-Hi@gemulon.postgresql.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

Refactor set of routines specific to elog.c

This refactors the following routines and facilities coming from
elog.c, to ease their use across multiple log destinations:
- Start timestamp, including its reset, to store when a process has been
started.
- The log timestamp, associated to an entry (the same timestamp is used
when logging across multiple destinations).
- Routine deciding if a query can be logged or not.
- The backend type names, depending on the process that logs any
information (postmaster, bgworker name or just GetBackendTypeDesc() with
a regular backend).
- Write of logs using the logging piped protocol, with the log collector
enabled.
- Error severity converted to a string.

These refactored routines will be used for some follow-up changes
to move all the csvlog logic into its own file and to potentially add
JSON as log destination, reducing the overall size of elog.c as the end
result.

Author: Michael Paquier, Sehrope Sarkuni
Reviewed-by: Nathan Bossart
Discussion: https://postgr.es/m/CAH7T-aqswBM6JWe4pDehi1uOiufqe06DJWaU5=X7dDLyqUExHg@mail.gmail.com

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/ac7c80758a7ad6369aefce7406f08c689144ec4b

Modified Files
--------------
src/backend/utils/error/elog.c | 159 ++++++++++++++++++++++++++---------------
src/include/utils/elog.h | 12 ++++
2 files changed, 112 insertions(+), 59 deletions(-)

Browse pgsql-committers by date

  From Date Subject
Next Message Michael Paquier 2022-01-12 06:04:43 pgsql: Move any code specific to log_destination=csvlog to its own file
Previous Message Michael Paquier 2022-01-12 03:40:33 pgsql: Fix comment related to pg_cryptohash_error()