pgsql: Handle mixed returnable and non-returnable columns better in IOS

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: pgsql-committers(at)lists(dot)postgresql(dot)org
Subject: pgsql: Handle mixed returnable and non-returnable columns better in IOS
Date: 2022-01-03 21:12:21
Message-ID: E1n4Ucv-0004LV-MI@gemulon.postgresql.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

Handle mixed returnable and non-returnable columns better in IOS.

We can revert the code changes of commit b5febc1d1 now, because
commit 9a3ddeb51 installed a real solution for the difficulty
that b5febc1d1 just dodged, namely that the planner might pick
the wrong one of several index columns nominally containing the
same value. It only matters which one we pick if we pick one
that's not returnable, and that mistake is now foreclosed.

Although both of the aforementioned commits were back-patched,
I don't feel a need to take any risk by back-patching this one.
The cases that it improves are very corner-ish.

Discussion: https://postgr.es/m/3179992.1641150853@sss.pgh.pa.us

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/8a2e323f208557acbfdc911516e84ec017f5a6ca

Modified Files
--------------
contrib/btree_gist/expected/inet.out | 8 ++++----
contrib/btree_gist/sql/inet.sql | 2 +-
src/backend/optimizer/path/indxpath.c | 15 +--------------
3 files changed, 6 insertions(+), 19 deletions(-)

Browse pgsql-committers by date

  From Date Subject
Next Message Tom Lane 2022-01-03 23:14:06 pgsql: Tab completion: don't offer valid constraints in VALIDATE CONSTR
Previous Message Tom Lane 2022-01-03 20:42:55 pgsql: Fix index-only scan plans, take 2.