From: | Michael Paquier <michael(at)paquier(dot)xyz> |
---|---|
To: | pgsql-committers(at)lists(dot)postgresql(dot)org |
Subject: | pgsql: Correct comment and some documentation about REPLICA_IDENTITY_IN |
Date: | 2021-12-22 07:39:35 |
Message-ID: | E1mzwDn-0004bQ-Cx@gemulon.postgresql.org |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-committers |
Correct comment and some documentation about REPLICA_IDENTITY_INDEX
catalog/pg_class.h was stating that REPLICA_IDENTITY_INDEX with a
dropped index is equivalent to REPLICA_IDENTITY_DEFAULT. The code tells
a different story, as it is equivalent to REPLICA_IDENTITY_NOTHING.
The behavior exists since the introduction of replica identities, and
fe7fd4e even added tests for this case but I somewhat forgot to fix this
comment.
While on it, this commit reorganizes the documentation about replica
identities on the ALTER TABLE page, and a note is added about the case
of dropped indexes with REPLICA_IDENTITY_INDEX.
Author: Michael Paquier, Wei Wang
Reviewed-by: Euler Taveira
Discussion: https://postgr.es/m/OS3PR01MB6275464AD0A681A0793F56879E759@OS3PR01MB6275.jpnprd01.prod.outlook.com
Backpatch-through: 10
Branch
------
REL_14_STABLE
Details
-------
https://git.postgresql.org/pg/commitdiff/420f9ac1b77cca142d4ab7919a4f2b703c1278b8
Modified Files
--------------
doc/src/sgml/ref/alter_table.sgml | 51 +++++++++++++++++++++++++++++++++------
src/include/catalog/pg_class.h | 2 +-
2 files changed, 44 insertions(+), 9 deletions(-)
From | Date | Subject | |
---|---|---|---|
Next Message | Peter Eisentraut | 2021-12-22 07:49:06 | pgsql: Fix incorrect format placeholders |
Previous Message | Peter Eisentraut | 2021-12-22 06:52:52 | pgsql: Fix typo in code comment |