From: | Daniel Gustafsson <dgustafsson(at)postgresql(dot)org> |
---|---|
To: | pgsql-committers(at)lists(dot)postgresql(dot)org |
Subject: | pgsql: Use test-specific temp path for keys during SSL test |
Date: | 2021-11-30 10:50:16 |
Message-ID: | E1ms0iG-00050S-1f@gemulon.postgresql.org |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-committers |
Use test-specific temp path for keys during SSL test
The SSL and SCRAM TAP test suites both use temporary copies of the
supplied test keys in order to ensure correct permissions. These
were however copied inside the tree using temporary filenames rather
than a true temporary folder. Fix by using tmp_check supplied by
PostgreSQL::Test::Utils. Spotted by Tom Lane during review of the
nearby sslinfo TAP test patch.
Reviewed-by: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Discussion: https://postgr.es/m/599244.1638041239@sss.pgh.pa.us
Branch
------
master
Details
-------
https://git.postgresql.org/pg/commitdiff/c113d8ad50d62bfcc16bbd5ceec91122e0046ede
Modified Files
--------------
src/test/ssl/ssl/.gitignore | 1 -
src/test/ssl/t/001_ssltests.pl | 85 ++++++++++++++++++++----------------------
src/test/ssl/t/002_scram.pl | 5 +--
3 files changed, 42 insertions(+), 49 deletions(-)
From | Date | Subject | |
---|---|---|---|
Next Message | Daniel Gustafsson | 2021-11-30 13:08:05 | pgsql: Remove PF_USED_FOR_ASSERTS_ONLY from variables in general use |
Previous Message | Amit Kapila | 2021-11-30 09:31:17 | Re: pgsql: Add a view to show the stats of subscription workers. |