pgsql: Fix determination of broken LSN in OVERWRITTEN_CONTRECORD

From: Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org>
To: pgsql-committers(at)lists(dot)postgresql(dot)org
Subject: pgsql: Fix determination of broken LSN in OVERWRITTEN_CONTRECORD
Date: 2021-11-26 15:47:54
Message-ID: E1mqdS6-00073O-I2@gemulon.postgresql.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

Fix determination of broken LSN in OVERWRITTEN_CONTRECORD

In commit ff9f111bce24 I mixed up inconsistent definitions of the LSN of
the first record in a page, when the previous record ends exactly at the
page boundary. The correct LSN is adjusted to skip the WAL page header;
I failed to use that when setting XLogReaderState->overwrittenRecPtr,
so at WAL replay time VerifyOverwriteContrecord would refuse to let
replay continue past that record.

Backpatch to 10. 9.6 also contains this bug, but it's no longer being
maintained.

Discussion: https://postgr.es/m/45597.1637694259@sss.pgh.pa.us

Branch
------
REL_10_STABLE

Details
-------
https://git.postgresql.org/pg/commitdiff/72cf39d51ade63954c868bfe93996b4be7a79bf5

Modified Files
--------------
src/backend/access/transam/xlogreader.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

Browse pgsql-committers by date

  From Date Subject
Next Message Alvaro Herrera 2021-11-26 17:33:04 pgsql: Document units for max_slot_wal_keep_size
Previous Message Robert Haas 2021-11-26 15:24:15 Re: pgsql: xlog.c: Remove global variables ReadRecPtr and EndRecPtr.