pgsql: Fix GRANTED BY support in REVOKE ROLE statements

From: Daniel Gustafsson <dgustafsson(at)postgresql(dot)org>
To: pgsql-committers(at)lists(dot)postgresql(dot)org
Subject: pgsql: Fix GRANTED BY support in REVOKE ROLE statements
Date: 2021-11-26 13:15:49
Message-ID: E1mqb4v-00066U-2z@gemulon.postgresql.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

Fix GRANTED BY support in REVOKE ROLE statements

Commit 6aaaa76bb added support for the GRANTED BY clause in GRANT and
REVOKE statements, but missed adding support for checking the role in
the REVOKE ROLE case. Fix by checking that the parsed role matches the
CURRENT_ROLE/CURRENT_USER requirement, and also add some tests for it.
Backpatch to v14 where GRANTED BY support was introduced.

Discussion: https://postgr.es/m/B7F6699A-A984-4943-B9BF-CEB84C003527@yesql.se
Backpatch-through: 14

Branch
------
REL_14_STABLE

Details
-------
https://git.postgresql.org/pg/commitdiff/371087d006e04991080bf17cf2287db38d3ea92e

Modified Files
--------------
src/backend/commands/user.c | 11 +++++++++++
src/backend/parser/gram.y | 2 ++
src/test/regress/expected/privileges.out | 9 +++++++++
src/test/regress/sql/privileges.sql | 8 ++++++++
4 files changed, 30 insertions(+)

Browse pgsql-committers by date

  From Date Subject
Next Message Robert Haas 2021-11-26 15:24:15 Re: pgsql: xlog.c: Remove global variables ReadRecPtr and EndRecPtr.
Previous Message Daniel Gustafsson 2021-11-26 13:15:19 pgsql: Fix GRANTED BY support in REVOKE ROLE statements