From: | Michael Paquier <michael(at)paquier(dot)xyz> |
---|---|
To: | pgsql-committers(at)lists(dot)postgresql(dot)org |
Subject: | pgsql: Block ALTER TABLE .. DROP NOT NULL on columns in replica identit |
Date: | 2021-11-25 06:06:36 |
Message-ID: | E1mq7u0-0003tw-I4@gemulon.postgresql.org |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-committers |
Block ALTER TABLE .. DROP NOT NULL on columns in replica identity index
Replica identities that depend directly on an index rely on a set of
properties, one of them being that all the columns defined in this index
have to be marked as NOT NULL. There was a hole in the logic with ALTER
TABLE DROP NOT NULL, where it was possible to remove the NOT NULL
property of a column part of an index used as replica identity, so block
it to avoid problems with logical decoding down the road.
The same check was already done columns part of a primary key, so the
fix is straight-forward.
Author: Haiying Tang, Hou Zhijie
Reviewed-by: Dilip Kumar, Michael Paquier
Discussion: https://postgr.es/m/OS0PR01MB6113338C102BEE8B2FFC5BD9FB619@OS0PR01MB6113.jpnprd01.prod.outlook.com
Backpatch-through: 10
Branch
------
master
Details
-------
https://git.postgresql.org/pg/commitdiff/f0d43947a1b0c30f0bf2c117cd78bf95a3161268
Modified Files
--------------
src/backend/commands/tablecmds.c | 31 ++++++++++++++++++--------
src/test/regress/expected/replica_identity.out | 4 ++++
src/test/regress/sql/replica_identity.sql | 4 ++++
3 files changed, 30 insertions(+), 9 deletions(-)
From | Date | Subject | |
---|---|---|---|
Next Message | Peter Eisentraut | 2021-11-25 13:35:10 | pgsql: Remove unneeded Python includes |
Previous Message | Michael Paquier | 2021-11-25 03:17:59 | pgsql: Fix fstat() emulation on Windows with standard streams |