From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
---|---|
To: | pgsql-committers(at)lists(dot)postgresql(dot)org |
Subject: | pgsql: Probe $PROVE not $PERL while checking for modules needed by TAP |
Date: | 2021-11-22 17:55:29 |
Message-ID: | E1mpDXN-0008Lh-49@gemulon.postgresql.org |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-committers |
Probe $PROVE not $PERL while checking for modules needed by TAP tests.
Normally "prove" and "perl" come from the same Perl installation,
but we support the case where they don't (mainly because the MSys
buildfarm animals need this). In that case, AX_PROG_PERL_MODULES
is completely the wrong thing to use, because it's checking what
"perl" has. Instead, make a little TAP test script including the
required modules, and run that under "prove".
We don't need ax_prog_perl_modules.m4 at all after this change,
so remove it.
Back-patch to all supported branches, for the buildfarm's benefit.
(In v10, this also back-patches the effects of commit 264eb03aa.)
Andrew Dunstan and Tom Lane, per an observation by Noah Misch
Discussion: https://postgr.es/m/E1moZHS-0002Cu-Ei@gemulon.postgresql.org
Branch
------
REL_12_STABLE
Details
-------
https://git.postgresql.org/pg/commitdiff/0416c9c18b35c85dd55eb35cd08a4b66564301c1
Modified Files
--------------
aclocal.m4 | 1 -
config/ax_prog_perl_modules.m4 | 77 -----------------------------
config/check_modules.pl | 20 ++++++++
configure | 108 +++++++----------------------------------
configure.in | 26 +++++-----
5 files changed, 53 insertions(+), 179 deletions(-)
From | Date | Subject | |
---|---|---|---|
Next Message | Tom Lane | 2021-11-22 20:26:05 | pgsql: Fix pg_dump --inserts mode for generated columns with dropped co |
Previous Message | Alvaro Herrera | 2021-11-22 16:45:21 | pgsql: Be more specific about OOM in XLogReaderAllocate |