pgsql: Improve publication error messages

Improve publication error messages

Commit 81d5995b4b introduced more fine-grained errormessages for
incorrect relkinds for publication, while unlogged and temporary
tables were reported with using the same message. This provides
separate error messages for these types of relpersistence.

Author: Bharath Rupireddy <bharath(dot)rupireddyforpostgres(at)gmail(dot)com>
Reviewed-by: Peter Eisentraut <peter(dot)eisentraut(at)enterprisedb(dot)com>
Reviewed-by: Jeevan Ladhe <jeevan(dot)ladhe(at)enterprisedb(dot)com>
Reviewed-by: Euler Taveira <euler(at)eulerto(dot)com>
Discussion: https://postgr.es/m/CALj2ACW9S=AswyQHjtO6WMcsergMkCBTtzXGrM8DX26DzfeTLQ@mail.gmail.com

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/aa12781b0d039d93e1a851ece4bc75c3746cbd43

Modified Files
--------------
contrib/postgres_fdw/expected/postgres_fdw.out | 6 ++++++
contrib/postgres_fdw/sql/postgres_fdw.sql | 5 +++++
src/backend/catalog/pg_publication.c | 10 ++++++++--
src/test/regress/expected/publication.out | 16 ++++++++++++++++
src/test/regress/sql/publication.sql | 14 ++++++++++++++
5 files changed, 49 insertions(+), 2 deletions(-)