pgsql: Avoid crash in rare case of concurrent DROP

From: Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org>
To: pgsql-committers(at)lists(dot)postgresql(dot)org
Subject: pgsql: Avoid crash in rare case of concurrent DROP
Date: 2021-11-05 15:33:21
Message-ID: E1mj1DV-0008VL-Pv@gemulon.postgresql.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

Avoid crash in rare case of concurrent DROP

When a role being dropped contains is referenced by catalog objects that
are concurrently also being dropped, a crash can result while trying to
construct the string that describes the objects. Suppress that by
ignoring objects whose descriptions are returned as NULL.

The majority of relevant codesites were already cautious about this
already; we had just missed a couple.

This is an old bug, so backpatch all the way back.

Reported-by: Alexander Lakhin <exclusion(at)gmail(dot)com>
Discussion: https://postgr.es/m/17126-21887f04508cb5c8@postgresql.org

Branch
------
REL_11_STABLE

Details
-------
https://git.postgresql.org/pg/commitdiff/92224e470c830e73636de20689690f28037cd019

Modified Files
--------------
src/backend/catalog/dependency.c | 31 ++++++++++++++++++++-----------
src/backend/catalog/pg_shdepend.c | 6 ++++++
2 files changed, 26 insertions(+), 11 deletions(-)

Browse pgsql-committers by date

  From Date Subject
Next Message Peter Geoghegan 2021-11-05 15:40:29 Re: pgsql: Add various assertions to heap pruning code.
Previous Message Alvaro Herrera 2021-11-05 15:09:59 pgsql: Document that ALTER TABLE .. TYPE removes statistics