From: | Fujii Masao <fujii(at)postgresql(dot)org> |
---|---|
To: | pgsql-committers(at)lists(dot)postgresql(dot)org |
Subject: | pgsql: pgbench: Improve error-handling in pgbench. |
Date: | 2021-11-02 13:50:57 |
Message-ID: | E1mhuBl-0007mf-7I@gemulon.postgresql.org |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-committers |
pgbench: Improve error-handling in pgbench.
Previously failures of initial connection and logfile open caused pgbench
to proceed the benchmarking, report the incomplete results and exit with
status 2. It didn't make sense to proceed the benchmarking even when
pgbench could not start as prescribed.
This commit improves pgbench so that early errors that occur when
starting benchmark such as those failures should make pgbench exit
immediately with status 1.
Author: Yugo Nagata
Reviewed-by: Fabien COELHO, Kyotaro Horiguchi, Fujii Masao
Discussion: https://postgr.es/m/TYCPR01MB5870057375ACA8A73099C649F5349@TYCPR01MB5870.jpnprd01.prod.outlook.com
Branch
------
master
Details
-------
https://git.postgresql.org/pg/commitdiff/cd29be5459f0e138c0f19d49ee588feeda78e3c9
Modified Files
--------------
doc/src/sgml/ref/pgbench.sgml | 10 ++++++----
src/bin/pgbench/pgbench.c | 26 +++++++++++++++-----------
2 files changed, 21 insertions(+), 15 deletions(-)
From | Date | Subject | |
---|---|---|---|
Next Message | Fujii Masao | 2021-11-02 14:09:52 | pgsql: pgbench: Fix typo in comment. |
Previous Message | Amit Kapila | 2021-11-02 03:50:17 | pgsql: Move MarkCurrentTransactionIdLoggedIfAny() out of the critical s |