From: | Daniel Gustafsson <dgustafsson(at)postgresql(dot)org> |
---|---|
To: | pgsql-committers(at)lists(dot)postgresql(dot)org |
Subject: | pgsql: Replace unicode characters in comments with ascii |
Date: | 2021-11-01 21:56:02 |
Message-ID: | E1mhfHe-0002Ac-KQ@gemulon.postgresql.org |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-committers |
Replace unicode characters in comments with ascii
The unicode characters, while in comments and not code, caused MSVC
to emit compiler warning C4819:
The file contains a character that cannot be represented in the
current code page (number). Save the file in Unicode format to
prevent data loss.
Fix by replacing the characters in print.c with descriptive comments
containing the codepoints and symbol names, and remove the character
in brin_bloom.c which was a footnote reference copied from the paper
citation.
Per report from hamerkop in the buildfarm.
Reviewed-by: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Discussion: https://postgr.es/m/340E4118-0D0C-4E85-8141-8C40EB22DA3A@yesql.se
Branch
------
master
Details
-------
https://git.postgresql.org/pg/commitdiff/43a134f28b350c4b731db9dddf2f53c407a7077f
Modified Files
--------------
src/backend/access/brin/brin_bloom.c | 2 +-
src/fe_utils/print.c | 110 ++++++++++++++++++++++++++++-------
2 files changed, 91 insertions(+), 21 deletions(-)
From | Date | Subject | |
---|---|---|---|
Next Message | Amit Kapila | 2021-11-02 03:13:44 | pgsql: Replace XLOG_INCLUDE_XID flag with a more localized flag. |
Previous Message | Tom Lane | 2021-11-01 20:24:56 | pgsql: Avoid some other O(N^2) hazards in list manipulation. |