pgsql: Fix frontend version of sh_error() in simplehash.h.

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: pgsql-committers(at)lists(dot)postgresql(dot)org
Subject: pgsql: Fix frontend version of sh_error() in simplehash.h.
Date: 2021-10-22 20:43:51
Message-ID: E1me1OJ-00031n-W8@gemulon.postgresql.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

Fix frontend version of sh_error() in simplehash.h.

The code does not expect sh_error() to return, but the patch
that made this header usable in frontend didn't get that memo.

While here, plaster unlikely() on the tests that decide whether
to invoke sh_error(), and add our standard copyright notice.

Noted by Andres Freund. Back-patch to v13 where this frontend
support came in.

Discussion: https://postgr.es/m/0D54435C-1199-4361-9D74-2FBDCF8EA164@anarazel.de

Branch
------
REL_14_STABLE

Details
-------
https://git.postgresql.org/pg/commitdiff/8cee4be6dc931c74870f57a7697b031838876da4

Modified Files
--------------
src/include/lib/simplehash.h | 14 +++++++++-----
1 file changed, 9 insertions(+), 5 deletions(-)

Browse pgsql-committers by date

  From Date Subject
Next Message Tom Lane 2021-10-22 20:43:52 pgsql: Fix frontend version of sh_error() in simplehash.h.
Previous Message Tom Lane 2021-10-22 19:22:49 pgsql: pg_dump: fix mis-dumping of non-global default privileges.