pgsql: Improve pg_regress.c's infrastructure for issuing psql commands.

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: pgsql-committers(at)lists(dot)postgresql(dot)org
Subject: pgsql: Improve pg_regress.c's infrastructure for issuing psql commands.
Date: 2021-10-20 22:44:44
Message-ID: E1mdKKC-0004M2-3u@gemulon.postgresql.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

Improve pg_regress.c's infrastructure for issuing psql commands.

Support issuing more than one "-c command" switch to a single
psql invocation. This allows combining some things that formerly
required two or more backend launches into a single session.
In particular, we can issue DROP DATABASE as one of the -c commands
without getting "DROP DATABASE cannot run inside a transaction block".

In addition to reducing the number of sessions needed, this patch
also suppresses "NOTICE: database "foo" does not exist, skipping"
chatter that was formerly generated during pg_regress's DROP DATABASE
(or ROLE) IF NOT EXISTS calls. That moves us another step closer
to the ideal of not seeing any messages during successful build/test.

This also eliminates some hard-coded restrictions on the length of
the commands issued. I don't think we were anywhere near hitting
those, but getting rid of the limit is comforting.

Patch by me, but thanks to Nathan Bossart for starting the discussion.

Discussion: https://postgr.es/m/DCBAE0E4-BD56-482F-8A70-7FD0DC0860BE@amazon.com

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/f45dc59a38cab1d2af6baaedb79559fe2e9b3781

Modified Files
--------------
src/test/regress/pg_regress.c | 148 +++++++++++++++++++++++++++++-------------
1 file changed, 104 insertions(+), 44 deletions(-)

Browse pgsql-committers by date

  From Date Subject
Next Message Michael Paquier 2021-10-21 01:42:23 pgsql: Fix corruption of pg_shdepend when copying deps from template da
Previous Message Tom Lane 2021-10-20 21:48:39 Re: pgsql: Reference test binary using TESTDIR in 001_libpq_pipeline.pl.