pgsql: Fix sscanf limits in pg_dump

From: Daniel Gustafsson <dgustafsson(at)postgresql(dot)org>
To: pgsql-committers(at)lists(dot)postgresql(dot)org
Subject: pgsql: Fix sscanf limits in pg_dump
Date: 2021-10-19 11:20:26
Message-ID: E1mcnAQ-0000Is-RZ@gemulon.postgresql.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

Fix sscanf limits in pg_dump

Make sure that the string parsing is limited by the size of the
destination buffer.

The buffer is bounded by MAXPGPATH, and thus the limit must be
inserted via preprocessor expansion and the buffer increased by
one to account for the terminator. There is no risk of overflow
here, since in this case, the buffer scanned is smaller than the
destination buffer.

Backpatch all the way down to 9.6.

Reviewed-by: Tom Lane
Discussion: https://postgr.es/m/B14D3D7B-F98C-4E20-9459-C122C67647FB@yesql.se
Backpatch-through: 9.6

Branch
------
REL_10_STABLE

Details
-------
https://git.postgresql.org/pg/commitdiff/abdf81a20ba2ddc06a0ebdd58ee8747306fb2004

Modified Files
--------------
src/bin/pg_dump/pg_backup_directory.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)

Browse pgsql-committers by date

  From Date Subject
Next Message Daniel Gustafsson 2021-10-19 11:20:32 pgsql: Fix bug in TOC file error message printing
Previous Message Daniel Gustafsson 2021-10-19 11:20:17 pgsql: Fix bug in TOC file error message printing