| From: | Heikki Linnakangas <heikki(dot)linnakangas(at)iki(dot)fi> |
|---|---|
| To: | pgsql-committers(at)lists(dot)postgresql(dot)org |
| Subject: | pgsql: Fix parallel sort, broken by the balanced merge patch. |
| Date: | 2021-10-18 17:49:09 |
| Message-ID: | E1mcWl3-0002ZE-0k@gemulon.postgresql.org |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-committers |
Fix parallel sort, broken by the balanced merge patch.
The code for initializing the tapes on each merge iteration was skipped
in a parallel worker. I put the !WORKER(state) check in wrong place while
rebasing the patch.
That caused failures in the index build in 'multiple-row-versions'
isolation test, in multiple buildfarm members. On my laptop it was easier
to reproduce by building an index on a larger table, so that you got a
parallel sort more reliably.
Branch
------
master
Details
-------
https://git.postgresql.org/pg/commitdiff/fc0f3b4cb0e882a9c5d51c302d4aa3591e4f80fd
Modified Files
--------------
src/backend/utils/sort/tuplesort.c | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Alvaro Herrera | 2021-10-18 22:12:32 | pgsql: Invalidate partitions of table being attached/detached |
| Previous Message | Andrew Dunstan | 2021-10-18 15:39:08 | Re: pgsql: Reference test binary using TESTDIR in 001_libpq_pipeline.pl. |