pgsql: Fix TestLib::slurp_file() with offset on windows.

From: Andres Freund <andres(at)anarazel(dot)de>
To: pgsql-committers(at)lists(dot)postgresql(dot)org
Subject: pgsql: Fix TestLib::slurp_file() with offset on windows.
Date: 2021-10-04 20:49:26
Message-ID: E1mXUtq-0007Om-B0@gemulon.postgresql.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

Fix TestLib::slurp_file() with offset on windows.

3c5b0685b921 used setFilePointer() to set the position of the filehandle, but
passed the wrong filehandle, always leaving the position at 0. Instead of just
fixing that, remove use of setFilePointer(), we have a perl fd at this point,
so we can just use perl's seek().

Additionally, the perl filehandle wasn't closed, just the windows filehandle.

Reviewed-By: Andrew Dunstan <andrew(at)dunslane(dot)net>
Author: Andres Freund <andres(at)anarazel(dot)de>
Discussion: https://postgr.es/m/20211003173038.64mmhgxctfqn7wl6@alap3.anarazel.de
Backpatch: 9.6-, like 3c5b0685b921

Branch
------
REL9_6_STABLE

Details
-------
https://git.postgresql.org/pg/commitdiff/9e3be5c182d71d7575aa2e63d9604bfa715a432e

Modified Files
--------------
src/test/perl/TestLib.pm | 36 ++++++++++++++++++------------------
1 file changed, 18 insertions(+), 18 deletions(-)

Browse pgsql-committers by date

  From Date Subject
Next Message Bruce Momjian 2021-10-04 21:11:35 pgsql: doc: remove URL for ICU explorer/locexp
Previous Message Andres Freund 2021-10-04 20:49:23 pgsql: Fix TestLib::slurp_file() with offset on windows.