pgsql: Fix TestLib::slurp_file() with offset on windows.

From: Andres Freund <andres(at)anarazel(dot)de>
To: pgsql-committers(at)lists(dot)postgresql(dot)org
Subject: pgsql: Fix TestLib::slurp_file() with offset on windows.
Date: 2021-10-04 20:49:12
Message-ID: E1mXUtc-0007Ma-9r@gemulon.postgresql.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

Fix TestLib::slurp_file() with offset on windows.

3c5b0685b921 used setFilePointer() to set the position of the filehandle, but
passed the wrong filehandle, always leaving the position at 0. Instead of just
fixing that, remove use of setFilePointer(), we have a perl fd at this point,
so we can just use perl's seek().

Additionally, the perl filehandle wasn't closed, just the windows filehandle.

Reviewed-By: Andrew Dunstan <andrew(at)dunslane(dot)net>
Author: Andres Freund <andres(at)anarazel(dot)de>
Discussion: https://postgr.es/m/20211003173038.64mmhgxctfqn7wl6@alap3.anarazel.de
Backpatch: 9.6-, like 3c5b0685b921

Branch
------
REL_14_STABLE

Details
-------
https://git.postgresql.org/pg/commitdiff/c4465cd09e3ab034ced25e623d5760e9ce437f6c

Modified Files
--------------
src/test/perl/TestLib.pm | 36 ++++++++++++++++++------------------
1 file changed, 18 insertions(+), 18 deletions(-)

Browse pgsql-committers by date

  From Date Subject
Next Message Andres Freund 2021-10-04 20:49:15 pgsql: Fix TestLib::slurp_file() with offset on windows.
Previous Message Andres Freund 2021-10-04 20:49:09 pgsql: Fix TestLib::slurp_file() with offset on windows.