From: | Daniel Gustafsson <dgustafsson(at)postgresql(dot)org> |
---|---|
To: | pgsql-committers(at)lists(dot)postgresql(dot)org |
Subject: | pgsql: pgcrypto: Check for error return of px_cipher_decrypt() |
Date: | 2021-09-25 09:48:30 |
Message-ID: | E1mU4II-0003Bi-72@gemulon.postgresql.org |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-committers |
pgcrypto: Check for error return of px_cipher_decrypt()
This has previously not been a problem (that anyone ever reported),
but in future OpenSSL versions (3.0.0), where legacy ciphers are/can
be disabled, this is the place where this is reported. So we need to
catch the error here, otherwise the higher-level functions would
return garbage. The nearby encryption code already handled errors
similarly.
Author: Peter Eisentraut <peter(at)eisentraut(dot)org>
Reviewed-by: Daniel Gustafsson <daniel(at)yesql(dot)se>
Discussion: https://www.postgresql.org/message-id/9e9c431c-0adc-7a6d-9b1a-915de1ba3fe7@enterprisedb.com
Backpatch-through: 9.6
Branch
------
REL_12_STABLE
Details
-------
https://git.postgresql.org/pg/commitdiff/90cfd269f226ecf287df7b8df04f6a46515000d4
Modified Files
--------------
contrib/pgcrypto/px.c | 5 ++++-
1 file changed, 4 insertions(+), 1 deletion(-)
From | Date | Subject | |
---|---|---|---|
Next Message | Daniel Gustafsson | 2021-09-25 09:48:42 | pgsql: Add alternative output for OpenSSL 3 without legacy loaded |
Previous Message | Daniel Gustafsson | 2021-09-25 09:47:32 | pgsql: Disable OpenSSL EVP digest padding in pgcrypto |