pgsql: Document issue with heapam line pointer truncation.

From: Peter Geoghegan <pg(at)bowt(dot)ie>
To: pgsql-committers(at)lists(dot)postgresql(dot)org
Subject: pgsql: Document issue with heapam line pointer truncation.
Date: 2021-09-23 02:21:49
Message-ID: E1mTEMv-00007x-Bs@gemulon.postgresql.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

Document issue with heapam line pointer truncation.

Checking that an offset number isn't past the end of a heap page's line
pointer array was just a defensive sanity check for HOT-chain traversal
code before commit 3c3b8a4b. It's etrictly necessary now, though. Add
comments that reference the issue to code in heapam that needs to get it
right.

Per suggestion from Alexander Lakhin.

Discussion: https://postgr.es/m/f76a292c-9170-1aef-91a0-59d9443b99a3@gmail.com

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/c7aeb775df895db240dcd6f47242f7e08899adfb

Modified Files
--------------
src/backend/access/heap/heapam.c | 11 +++++++++--
src/backend/access/heap/pruneheap.c | 22 ++++++++++++++++++----
2 files changed, 27 insertions(+), 6 deletions(-)

Browse pgsql-committers by date

  From Date Subject
Next Message Tomas Vondra 2021-09-23 16:20:43 pgsql: Release memory allocated by dependency_degree
Previous Message Fujii Masao 2021-09-22 14:48:54 pgsql: postgres_fdw: Refactor transaction rollback code to avoid code d