pgsql: Fix "single value strategy" index deletion issue.

From: Peter Geoghegan <pg(at)bowt(dot)ie>
To: pgsql-committers(at)lists(dot)postgresql(dot)org
Subject: pgsql: Fix "single value strategy" index deletion issue.
Date: 2021-09-22 02:01:54
Message-ID: E1mSra6-0008VM-5q@gemulon.postgresql.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

Fix "single value strategy" index deletion issue.

It is not appropriate for deduplication to apply single value strategy
when triggered by a bottom-up index deletion pass. This wastes cycles
because later bottom-up deletion passes will overinterpret older
duplicate tuples that deduplication actually just skipped over "by
design". It also makes bottom-up deletion much less effective for low
cardinality indexes that happen to cross a meaningless "index has single
key value per leaf page" threshold.

To fix, slightly narrow the conditions under which deduplication's
single value strategy is considered. We already avoided the strategy
for a unique index, since our high level goal must just be to buy time
for VACUUM to run (not to buy space). We'll now also avoid it when we
just had a bottom-up pass that reported failure. The two cases share
the same high level goal, and already overlapped significantly, so this
approach is quite natural.

Oversight in commit d168b666, which added bottom-up index deletion.

Author: Peter Geoghegan <pg(at)bowt(dot)ie>
Discussion: https://postgr.es/m/CAH2-WznaOvM+Gyj-JQ0X=JxoMDxctDTYjiEuETdAGbF5EUc3MA@mail.gmail.com
Backpatch: 14-, where bottom-up deletion was introduced.

Branch
------
REL_14_STABLE

Details
-------
https://git.postgresql.org/pg/commitdiff/e665129c4727004e7a7c12c86d077abc750b3307

Modified Files
--------------
src/backend/access/nbtree/nbtdedup.c | 36 +++++++++++++++++------------------
src/backend/access/nbtree/nbtinsert.c | 2 +-
src/include/access/nbtree.h | 2 +-
3 files changed, 19 insertions(+), 21 deletions(-)

Browse pgsql-committers by date

  From Date Subject
Next Message Amit Kapila 2021-09-22 02:24:18 pgsql: Add parent table name in an error in reorderbuffer.c.
Previous Message Michael Paquier 2021-09-22 02:01:05 Re: pgsql: Support "postgres -C" with runtime-computed GUCs