| From: | Michael Paquier <michael(at)paquier(dot)xyz> |
|---|---|
| To: | pgsql-committers(at)lists(dot)postgresql(dot)org |
| Subject: | pgsql: Remove code duplication for permission checks with replication s |
| Date: | 2021-09-14 01:16:15 |
| Message-ID: | E1mPx3X-0007ar-Dy@gemulon.postgresql.org |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-committers |
Remove code duplication for permission checks with replication slots
Two functions, both named check_permissions(), used the same checks to
verify if a user had required privileges to work on replication slots.
This commit removes the duplication, and moves the function doing the
checks to slot.c to be centralized.
Author: Bharath Rupireddy
Reviewed-by: Nathan Bossart, Euler Taveira
Discussion: https://postgr.es/m/CALj2ACUPpVw1u7sQocFVWrSs0n10pt_G_4NPZKSxXK6cW1dErw@mail.gmail.com
Branch
------
master
Details
-------
https://git.postgresql.org/pg/commitdiff/026ed8efd6b1d774924937baf3209b676df4531f
Modified Files
--------------
src/backend/replication/logical/logicalfuncs.c | 11 +----------
src/backend/replication/slot.c | 12 ++++++++++++
src/backend/replication/slotfuncs.c | 19 +++++--------------
src/include/replication/slot.h | 1 +
4 files changed, 19 insertions(+), 24 deletions(-)
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Andres Freund | 2021-09-14 01:31:08 | pgsql: jit: Do not try to shut down LLVM state in case of LLVM triggere |
| Previous Message | Andres Freund | 2021-09-14 00:01:53 | Re: pgsql: Deduplicate choice of horizon for a relation procarray.c. |