From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
---|---|
To: | pgsql-committers(at)lists(dot)postgresql(dot)org |
Subject: | pgsql: Further portability tweaks for float4/float8 hash functions. |
Date: | 2021-09-04 20:29:37 |
Message-ID: | E1mMcID-0002rd-U6@gemulon.postgresql.org |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-committers |
Further portability tweaks for float4/float8 hash functions.
Attempting to make hashfloat4() look as much as possible like
hashfloat8(), I'd figured I could replace NaNs with get_float4_nan()
before widening to float8. However, results from protosciurus
and topminnow show that on some platforms that produces a different
bit-pattern from get_float8_nan(), breaking the intent of ce773f230.
Rearrange so that we use the result of get_float8_nan() for all NaN
cases. As before, back-patch.
Branch
------
REL_11_STABLE
Details
-------
https://git.postgresql.org/pg/commitdiff/8782a84529035baca1639c3680458e2062ef9b44
Modified Files
--------------
src/backend/access/hash/hashfunc.c | 22 ++++++++++++----------
1 file changed, 12 insertions(+), 10 deletions(-)
From | Date | Subject | |
---|---|---|---|
Next Message | Michael Paquier | 2021-09-06 00:26:48 | pgsql: Remove some unused variables in TAP tests |
Previous Message | Tom Lane | 2021-09-04 17:28:23 | pgsql: Minor improvements for psql help output. |