pgsql: Refactor postgresImportForeignSchema to avoid code duplication.

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: pgsql-committers(at)lists(dot)postgresql(dot)org
Subject: pgsql: Refactor postgresImportForeignSchema to avoid code duplication.
Date: 2021-09-01 20:21:20
Message-ID: E1mLWjY-0006H6-GN@gemulon.postgresql.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

Refactor postgresImportForeignSchema to avoid code duplication.

Avoid repeating fragments of the query we're building, along the
same lines as recent cleanup in pg_dump. I got annoyed about this
because aa769f80e broke my pending patch to change postgres_fdw's
collation handling, due to each of us having incompletely done
this same refactoring. Let's finish that job in hopes of having
a more stable base.

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/2dc53fe2a77d8d5f22c656fdf6590198e358a996

Modified Files
--------------
contrib/postgres_fdw/postgres_fdw.c | 50 +++++++++++++++++--------------------
1 file changed, 23 insertions(+), 27 deletions(-)

Browse pgsql-committers by date

  From Date Subject
Next Message Tom Lane 2021-09-01 21:25:08 pgsql: Doc: clarify how triggers relate to transactions.
Previous Message Tomas Vondra 2021-09-01 16:40:04 pgsql: Identify simple column references in extended statistics