| From: | Daniel Gustafsson <dgustafsson(at)postgresql(dot)org> |
|---|---|
| To: | pgsql-committers(at)lists(dot)postgresql(dot)org |
| Subject: | pgsql: Remove --quiet option from pg_amcheck |
| Date: | 2021-08-20 10:48:57 |
| Message-ID: | E1mH253-000338-Be@gemulon.postgresql.org |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-committers |
Remove --quiet option from pg_amcheck
Using --quiet in combination with --no-strict-names didn't work as
documented, a warning message was still emitted. Since the --quiet
flag was working in an unconventional way to other utilities, fix
by removing the functionality instead.
Backpatch through 14 where pg_amcheck was introduced.
Bug: 17148
Reported-by: Chen Jiaoqian <chenjq(dot)jy(at)fujitsu(dot)com>
Reviewed-by: Julien Rouhaud <rjuju123(at)gmail(dot)com>
Discussion: https://postgr.es/m/17148-b5087318e2b04fc6@postgresql.org
Backpatch-through: 14
Branch
------
master
Details
-------
https://git.postgresql.org/pg/commitdiff/9a9c8b92018d4d48f93cd8fa1895c53fa5946d75
Modified Files
--------------
doc/src/sgml/ref/pg_amcheck.sgml | 12 ----------
src/bin/pg_amcheck/pg_amcheck.c | 38 ++++++++++--------------------
src/bin/pg_amcheck/t/002_nonesuch.pl | 6 ++++-
src/bin/pg_amcheck/t/003_check.pl | 2 +-
src/bin/pg_amcheck/t/005_opclass_damage.pl | 2 +-
5 files changed, 20 insertions(+), 40 deletions(-)
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Daniel Gustafsson | 2021-08-20 10:49:05 | pgsql: Remove --quiet option from pg_amcheck |
| Previous Message | Peter Eisentraut | 2021-08-20 09:44:14 | pgsql: psql: Add test for query canceling |