From: | Andres Freund <andres(at)anarazel(dot)de> |
---|---|
To: | pgsql-committers(at)lists(dot)postgresql(dot)org |
Subject: | pgsql: Unset MyBEEntry, making elog.c's call to pgstat_get_my_query_id( |
Date: | 2021-08-19 12:20:27 |
Message-ID: | E1mGh23-0002XJ-Lw@gemulon.postgresql.org |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-committers |
Unset MyBEEntry, making elog.c's call to pgstat_get_my_query_id() safe.
Previously log messages late during shutdown could end up using either another
backend's PgBackendStatus (multi user) or segfault (single user) because
pgstat_get_my_query_id()'s check for !MyBEEntry didn't filter out use after
pgstat_beshutdown_hook().
This became a bug in 4f0b0966c86, but was a bit fishy before. But given
there's no known problematic cases before 14, it doesn't seem worth
backpatching further.
Also fixes a wrong filename in a comment, introduced in e1025044.
Reported-By: Andres Freund <andres(at)anarazel(dot)de>
Reviewed-By: Julien Rouhaud <rjuju123(at)gmail(dot)com>
Discussion: https://postgr.es/m/Julien Rouhaud <rjuju123(at)gmail(dot)com>
Backpatch: 14-
Branch
------
master
Details
-------
https://git.postgresql.org/pg/commitdiff/bed5eac2d50eb86a254861dcdea7b064d10c72cf
Modified Files
--------------
src/backend/utils/activity/backend_status.c | 5 ++++-
1 file changed, 4 insertions(+), 1 deletion(-)
From | Date | Subject | |
---|---|---|---|
Next Message | Andres Freund | 2021-08-19 12:20:30 | pgsql: Unset MyBEEntry, making elog.c's call to pgstat_get_my_query_id( |
Previous Message | Amit Kapila | 2021-08-19 04:23:43 | Re: pgsql: pgstat: Bring up pgstat in BaseInit() to fix uninitialized use o |