| From: | Andres Freund <andres(at)anarazel(dot)de> |
|---|---|
| To: | pgsql-committers(at)lists(dot)postgresql(dot)org |
| Subject: | pgsql: pgbench: When using pipelining only do PQconsumeInput() when nec |
| Date: | 2021-08-05 02:24:13 |
| Message-ID: | E1mBT3N-00014q-9Q@gemulon.postgresql.org |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-committers |
pgbench: When using pipelining only do PQconsumeInput() when necessary.
Up to now we did a PQconsumeInput() for each pipelined query, asking the OS
for more input - which it often won't have, as all results might already have
been sent. That turns out to have a noticeable performance impact.
Alvaro Herrera reviewed the idea to add the PQisBusy() check, but not this
concrete patch.
Author: Andres Freund <andres(at)anarazel(dot)de>
Discussion: https://postgr.es/m/20210720180039.23rivhdft3l4mayn@alap3.anarazel.de
Backpatch: 14, where libpq/pgbench pipelining was introduced.
Branch
------
REL_14_STABLE
Details
-------
https://git.postgresql.org/pg/commitdiff/fa604e0dd07a39ba34f93d06ded8243280dffdeb
Modified Files
--------------
src/bin/pgbench/pgbench.c | 9 ++++++++-
1 file changed, 8 insertions(+), 1 deletion(-)
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Michael Paquier | 2021-08-05 06:02:56 | Re: pgsql: Enable TAP tests of pg_receivewal for ZLIB on Windows, take thre |
| Previous Message | Andres Freund | 2021-08-05 02:24:10 | pgsql: pgbench: When using pipelining only do PQconsumeInput() when nec |