pgsql: Avoid calling TestLib::perl2host on a symlinked directory

From: Andrew Dunstan <andrew(at)dunslane(dot)net>
To: pgsql-committers(at)lists(dot)postgresql(dot)org
Subject: pgsql: Avoid calling TestLib::perl2host on a symlinked directory
Date: 2021-07-29 16:18:28
Message-ID: E1m98js-0007Rx-TW@gemulon.postgresql.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

Avoid calling TestLib::perl2host on a symlinked directory

Certain versions of msys2/Windows have been observed to resolve symlinks
in perl2host rather than just follow them. This defeats using a
symlinked shorter path to a longer path, and makes certain tests fail.
We therefore call perl2host on the parent directory of the symlink and
thereafter just use that result.

Apply to release 14 where the problem has been observed.

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/b35a67bc04243da609843949c53e6841e748243a

Modified Files
--------------
src/bin/pg_basebackup/t/010_pg_basebackup.pl | 12 +++++++-----
1 file changed, 7 insertions(+), 5 deletions(-)

Browse pgsql-committers by date

  From Date Subject
Next Message Andrew Dunstan 2021-07-29 17:26:22 Re: pgsql: Re-enable TAP tests of pg_receivewal for ZLIB on Windows
Previous Message Amit Kapila 2021-07-29 10:30:39 pgsql: Refactor to make common functions in proto.c and worker.c.