| From: | Michael Paquier <michael(at)paquier(dot)xyz> |
|---|---|
| To: | pgsql-committers(at)lists(dot)postgresql(dot)org |
| Subject: | pgsql: Add missing exit() in pg_verifybackup when failing to find pg_wa |
| Date: | 2021-07-29 02:00:31 |
| Message-ID: | E1m8vLb-0001L1-6p@gemulon.postgresql.org |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-committers |
Add missing exit() in pg_verifybackup when failing to find pg_waldump
pg_verifybackup needs by default pg_waldump to check after a range of
WAL segments required for a backup, except if --no-parse-wal is
specified. The code checked for the presence of the binary pg_waldump
in an installation and reported an error, but it forgot to properly
exit(). This could lead to confusing errors reported.
Reviewed-by: Robert Haas, Fabien Coelho
Discussion: https://postgr.es/m/YQDMdB+B68yePFeT@paquier.xyz
Backpatch-through: 13
Branch
------
master
Details
-------
https://git.postgresql.org/pg/commitdiff/2ad98fdf53edf1a90123e3b189cc6f0a31986891
Modified Files
--------------
src/bin/pg_verifybackup/pg_verifybackup.c | 1 +
1 file changed, 1 insertion(+)
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Michael Paquier | 2021-07-29 02:44:34 | pgsql: Add some missing exit() calls in error paths for various binarie |
| Previous Message | David Rowley | 2021-07-29 00:01:46 | pgsql: Adjust MSVC build scripts to parse Makefiles for defines |